[codex] Add silent update availability checks - #32
Merged
Conversation
ygsgdbd
marked this pull request as ready for review
July 16, 2026 07:06
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a quiet Sparkle update probe when ListenBar launches. The app does not present an update window during this probe; instead, the menu entry changes from “Check for Updates…” to “New Version Available…” when a valid release is found.
Problem and user impact
ListenBar previously started Sparkle with automatic checks disabled and only checked for updates after the user selected the menu command. Users therefore had no passive indication that a newer release was available.
A naive probing implementation also risks leaving the menu command disabled forever: Sparkle documents that
checkForUpdateInformation()is a no-op when another update session is already in progress, so no completion callback is delivered in that case.Root cause
The app had no updater delegate or observable update state. The menu label was static and called the user-initiated Sparkle flow directly. There was also no guard around Sparkle's
sessionInProgressstate before entering the local checking state.Changes
SparkleUpdateMonitorto track idle, checking, and update-available states throughSPUUpdaterDelegatecallbacks.checkForUpdateInformation()once at app launch while keepingSUEnableAutomaticChecks=false.Validation
rtk tuist generate --no-openrtk xcodebuild build-for-testing -quiet -project ListenBar.xcodeproj -scheme ListenBar -destination 'platform=macOS' -skipPackagePluginValidation -skipMacroValidation CODE_SIGN_IDENTITY='' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NOrtk xcodebuild test-without-building -quiet -project ListenBar.xcodeproj -scheme ListenBar -destination 'platform=macOS' -testLanguage zh-Hans CODE_SIGN_IDENTITY='' CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NOgit diff --checkThe build continues to emit the repository's existing Swift 6
Sendablewarnings; all validation commands completed successfully.