Conversation
Remove whitespace in tutorial.
Changes to be committed: modified: website/docs/tutorial/index.mdx modified: website/versioned_docs/version-0.20/getting-started/build-a-sample-app.mdx modified: website/versioned_docs/version-0.20/tutorial/index.mdx
|
Visit the preview URL for this PR (updated for commit 75d3cab): https://yew-rs--pr3403-add-info-to-website-7u84pp0u.web.app (expires Sat, 30 Sep 2023 12:20:52 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ranile
left a comment
ranile
left a comment
There was a problem hiding this comment.
Thanks for the PR. I merged master into your branch. There's a few comments here to be addressed though
| #### Update Cargo.toml | ||
|
|
||
| Add `yew` to the list of dependencies. | ||
| Add `yew` to the list of dependencies editing file: |
There was a problem hiding this comment.
| Add `yew` to the list of dependencies editing file: | |
| Add `yew` to the list of dependencies by updating your Cargo.toml: |
There was a problem hiding this comment.
@hamza1311 suggested changes implemented in PR #3406.
| ```toml title="Trunk.toml" | ||
| [serve] | ||
| # The address to serve on. | ||
| address = "127.0.0.1" // "0.0.0.0" for WAN |
There was a problem hiding this comment.
| address = "127.0.0.1" // "0.0.0.0" for WAN | |
| address = "127.0.0.1" |
WAN is incorrect. 0.0.0.0 makes the port exposed on the local network. It has to be exposed. Also, it not recommended to use trunk for anything else other development so I would like to not recommend this
There was a problem hiding this comment.
@hamza1311 "0.0.0.0 for WAN" is for remote development (ssh client). I agree that is not recommended! But any alternative for this cases?
| application if you modify any source files. | ||
| This will fail if the socket is being used by another application. | ||
| By default server will listening at address '127.0.0.1' and port '8080' [localhost:8080](http://127.0.0.1:8080). | ||
| To change it, create the following file and edit as needed: |
There was a problem hiding this comment.
| To change it, create the following file and edit as needed: | |
| To change it, create the [Trunk config file](https://trunkrs.dev/configuration/#trunk-toml) and edit as needed: |
There was a problem hiding this comment.
@hamza1311 suggested changes implemented in PR #3406.
ranile
dismissed
github-actions[bot]’s stale review
Unintended automated review
|
These changes were included already so I'm going to close this PR |
2 participants
Description
Add more info to website.