Validate ActionBlock constructor inputs - #2
Open
yevhen wants to merge 1 commit into
Open
Conversation
yevhen
force-pushed
the
demo-actionblock-validation
branch
from
July 7, 2026 20:43
7ec68c9 to
5395e8e
Compare
yevhen
commented
Jul 7, 2026
yevhen
left a comment
yevhen
left a comment
Owner
Author
There was a problem hiding this comment.
One requested test coverage follow-up.
yevhen
commented
Jul 7, 2026
yevhen
left a comment
yevhen
left a comment
Owner
Author
There was a problem hiding this comment.
Review note: please add missing test coverage for the new action null-validation path.
| if (parallelism <= 0) | ||
| throw new ArgumentOutOfRangeException(nameof(parallelism), "Parallelism must be greater than 0."); | ||
|
|
||
| this.action = action ?? throw new ArgumentNullException(nameof(action)); |
Owner
Author
There was a problem hiding this comment.
This adds a new ArgumentNullException path for action, but the PR only tests invalid parallelism. Could we add a constructor validation test for action: null as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests