Skip to content

feat: add accessible iframe title to embed blocks #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YvetteNikolov merged 2 commits into from
Jun 30, 2026
Merged

feat: add accessible iframe title to embed blocks #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eeb5289
feat: add accessible iframe title to embed blocks
YvetteNikolov Jun 30, 2026
adf29b3
Potential fix for pull request finding
YvetteNikolov Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions src/Gutenberg.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,4 +120,70 @@ public function addGroupColumnCountClass(string $blockContent, array $block): st

return $processor->get_updated_html() ?: $blockContent;
}

/**
* Adds a descriptive title to embed iframes for accessibility - "YouTube video: ..."
* Embeds that render no iframe (Twitter, Instagram, ...) are skipped.
*/
Comment on lines +124 to +127

@YvetteNikolov YvetteNikolov Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

#[Filter('render_block_core/embed')]
public function addEmbedIframeTitle(string $blockContent, array $block): string
{
$providerSlug = $block['attrs']['providerNameSlug'] ?? '';

if (! is_string($providerSlug) || '' === $providerSlug) {
return $blockContent;
}

$label = $this->embedProviderLabel($providerSlug);

$type = $block['attrs']['type'] ?? '';
if (is_string($type) && in_array($type, ['video', 'audio'], true)) {
$label = sprintf('%s %s', $label, $type);
}
Comment on lines +139 to +142

@YvetteNikolov YvetteNikolov Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niet nodig, is zowel engels als nederlands


$processor = new \WP_HTML_Tag_Processor($blockContent);

$updated = false;
while ($processor->next_tag(['tag_name' => 'iframe'])) {
$existingTitle = $processor->get_attribute('title');
$existingTitle = is_string($existingTitle) ? trim($existingTitle) : '';

// Skip if label is already applied
if ('' !== $existingTitle && str_starts_with($existingTitle, $label)) {
continue;
}

$title = '' !== $existingTitle
? sprintf('%s: %s', $label, $existingTitle)
: $label;

$processor->set_attribute('title', $title);
$updated = true;
}

if (! $updated) {
return $blockContent;
}

return $processor->get_updated_html() ?: $blockContent;
}

private function embedProviderLabel(string $slug): string
{
$names = [
'youtube' => 'YouTube',
'vimeo' => 'Vimeo',
'dailymotion' => 'Dailymotion',
'ted' => 'TED',
'videopress' => 'VideoPress',
'wordpress-tv' => 'WordPress.tv',
'soundcloud' => 'SoundCloud',
'spotify' => 'Spotify',
'flickr' => 'Flickr',
'animoto' => 'Animoto',
'kickstarter' => 'Kickstarter',
];

return $names[$slug] ?? ucwords(str_replace('-', ' ', $slug));
}
}
Loading