Add CI workflow, git service specs, and CHANGELOG hygiene#6
Merged
Conversation
Closes the three biggest production-readiness gaps after v0.3.4: no CI to catch regressions on main, zero spec coverage on the 893-LOC E2B::Services::Git (including the credential URL helpers that handle secrets), and a stale CHANGELOG with no [Unreleased] section despite several real post-release fixes. Also drops the unused vcr development dependency (the suite is WebMock-only, no cassettes anywhere) and excludes .github/ from RuboCop so it stops trying to parse YAML as Ruby. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
redox
reviewed
May 10, 2026
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| ruby: ["3.0", "3.1", "3.2", "3.3"] |
Collaborator
There was a problem hiding this comment.
@ya-luotao I believe it's worth testing on 3.4 and maybe even 4.0 - I would maybe even remove 3.0
Owner
Author
There was a problem hiding this comment.
You make a good point, I will do that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/ci.ymlrunsbundle exec rake(rspec + rubocop) on Ruby 3.0/3.1/3.2/3.3 for every push/PR. Until now the localrakewas the only gate, so any regression that slipped past the maintainer's manual run could land onmain.E2B::Services::Git: newspec/e2b/services/git_spec.rb(12 examples) locks down credential URL embedding/stripping,git status --porcelain=v2parsing, branch listing, and auth/upstream error mapping. The 893-LOC service had zero spec coverage before; the credential helpers handle secrets and were entirely untested.[Unreleased]restored — records the post-0.3.4process.Process/Startretry-skip fix (128b1bc), the new CI, the new spec, and the unusedvcrdev-dep removal.vcrfromGemfile; exclude.github/**/*from RuboCop.Test plan
bundle exec rake spec— 134 examples, 0 failuresbundle exec rake rubocop— 47 files, 0 offenses/invariantsaudit — all three v0.3.4 invariants still intact (EnvdBase64 centralization,stdin: falsedefault,process.Process/Startnot retried)🤖 Generated with Claude Code