This repository was archived by the owner on Jan 16, 2023. It is now read-only.
add option for dmenu like behaviour#405
Open
yuri0r wants to merge 2 commits into
Open
Conversation
The -d option will overwrite the default XK_Enter behaviour. Instead of changing the mode sxiv will output the path to the currently fileindexed Image to stdout. In order to still be able to change modes ctrl+enter will irgnore -d flag and chnages modes as normaly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technicalities
The -d option will overwrite the default XK_Enter behaviour.
Instead of changing the mode sxiv will output the path to
the currently file indexed Image to stdout.
In order to still be able to change modes ctrl+enter will
ignore -d flag and changes modes as normally.
Notes
I am not a c dev but i feel like this was simple enough to implement and potentially some more people would like sxiv to more closely imitate dmenu behaviour.
Caveats
yes i am fully aware that -o -> mark one picture -> quit does effectively the same thing but the extra key press bothered me enough to dust of my c skills. I do however fully understand that this might seen as unnecessary in which case feel fee to decline the PR.