Skip to content

Remove cursor support from SubscribeAllEnvelopes#326

Merged
Maelkum merged 2 commits intomainfrom
maelkum/subscribe-all-remove-cursor-support
Mar 10, 2026
Merged

Remove cursor support from SubscribeAllEnvelopes#326
Maelkum merged 2 commits intomainfrom
maelkum/subscribe-all-remove-cursor-support

Conversation

@Maelkum
Copy link
Contributor

@Maelkum Maelkum commented Mar 10, 2026

As mentioned here the amount of data one could unintentionally stream is too large, so we're removing cursor support for "stream all".

Technically correct would be to have the reserve 1; directive, but this change was not really released and no one really relies on it so no breaking changes should happen.

Note

Remove last_seen cursor field from SubscribeAllEnvelopesRequest

Removes the last_seen cursor field from the SubscribeAllEnvelopesRequest proto message in message_api.proto, leaving it empty. Risk: callers that set or read last_seen will break; serialized requests that previously included a cursor will now be empty.

Macroscope summarized 21efdc8.

@Maelkum Maelkum self-assigned this Mar 10, 2026
@Maelkum Maelkum requested a review from a team as a code owner March 10, 2026 18:31
@macroscopeapp
Copy link
Contributor

macroscopeapp bot commented Mar 10, 2026

Approvability

Verdict: Approved

Simple proto schema change removing cursor support from SubscribeAllEnvelopesRequest. The author is the designated code owner of the modified file and a repo admin, indicating appropriate authority to make this API design decision.

You can customize Macroscope's approvability policy. Learn more.

@Maelkum Maelkum changed the title Maelkum/subscribe all remove cursor support Remove cursor support from SubscribeAllEnvelopes Mar 10, 2026
@Maelkum Maelkum merged commit ddc38df into main Mar 10, 2026
10 of 11 checks passed
@Maelkum Maelkum deleted the maelkum/subscribe-all-remove-cursor-support branch March 10, 2026 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants