[codex] Add local macOS integration harness#42
Draft
xcv58 wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #42 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 1191 1191
=========================================
Hits 1191 1191 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ShortcutCycleIntegrationTestsharness for real app switching on macOSfixtureLoaded,hudPresented,switchFinalized, anderroreventsWhy this changed
We needed a real macOS integration path that exercises the production switching flow against actual system apps instead of only unit-level abstractions. This gives us deterministic fixture setup, real frontmost-app assertions, and visual artifacts developers can inspect locally.
Developer impact
bash scripts/run_integration_harness.shlocally to build the isolated integration app, launch Calculator and Chess, execute the three-cycle scenario, and save screenshots under.artifacts/integration/<run-id>--videocan assemble a playback MP4 from the captured frames whenffmpegis availableRoot cause addressed
The earlier harness work had two main problems:
This PR adds the sandbox-aware harness plumbing and makes frame capture follow the relevant visible window before falling back to display preference heuristics.
Validation
xcodebuild build-for-testing -project ShortcutCycle/ShortcutCycle.xcodeproj -scheme ShortcutCycleIntegration -configuration Debug -destination 'platform=macOS' -derivedDataPath .artifacts/xcode-integration/DerivedData -clonedSourcePackagesDirPath .artifacts/xcode-integration/SourcePackages SHORTCUTCYCLE_APP_BUNDLE_IDENTIFIER=com.xcv58.ShortcutCycle.Integrationbash ShortcutCycle/scripts/run_integration_harness.shKnown issue
The real happy-path integration run still has an intermittent frontmost-app flake during the final assertion phase. The draft is intentional so we can review the harness structure and current behavior while that macOS focus race is still being tightened up.