Surface error even if we cannot parse ERROR lines in the output of restore#771
Merged
Surface error even if we cannot parse ERROR lines in the output of restore#771
Conversation
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
tsg
approved these changes
Mar 11, 2026
tsg
pushed a commit
that referenced
this pull request
Mar 11, 2026
…store (#771) Fix `RunPGRestore` producing `error restoring dump: %!w(<nil>)` when the command fails with a non-zero exit code but the output contains no parseable ERROR lines. Now falls back to the exec error instead of wrapping nil.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix
RunPGRestoreproducingerror restoring dump: %!w(<nil>)when the command fails with a non-zero exit code but the output contains no parseable ERROR lines. Now falls back to the exec error instead of wrapping nil.Type of Change
Please select the relevant option(s):
Changes Made
buildRestoreErrorfor testability and add tests covering all combinations of exec error and output parsingTesting
Checklist
Additional Notes