CP-311531: handle both 32-bit and 64-bit unreachable distances in the NUMA matrix#6897
Open
edwintorok wants to merge 1 commit intoxapi-project:masterfrom
Open
CP-311531: handle both 32-bit and 64-bit unreachable distances in the NUMA matrix#6897edwintorok wants to merge 1 commit intoxapi-project:masterfrom
edwintorok wants to merge 1 commit intoxapi-project:masterfrom
Conversation
Member
Author
|
Although <10 already had code to handle it in is_numa_matrix_reasonable, so maybe I'll change that to <0. |
edwintorok
force-pushed
the
private/edvint/distance
branch
from
355a33f to
3b0eaca
Compare
… NUMA matrix Also <10 is invalid, which is convenient for detecting the 64-bit unreachable value. But that is already handled in is_numa_matrix_reasonable, so treat just <0 as unreachable. Signed-off-by: Edwin Török <edwin.torok@citrix.com>
edwintorok
force-pushed
the
private/edvint/distance
branch
from
3b0eaca to
79934fb
Compare
edwintorok
changed the title
lindig
reviewed
Feb 9, 2026
| let is_unreachable d = d > max_valid_distance || d < 0 | ||
|
|
||
| let () = | ||
| (* 32-bit *) |
Contributor
There was a problem hiding this comment.
I am a bit surprised that when this is read from Xen and converted to an int, that it is not sign extended and thus would be -1 in all cases. it seems we are currently treating the return value as an unsigned number.
lindig
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also <10 is invalid, which is convenient for detecting the 64-bit unreachable value, but this is already handled.