LVHDSR: convert VDI.ref retured by get_snapshot_of to vdi_uuid#781
Merged
MarkSymsCtx merged 4 commits intoxapi-project:masterfrom Jan 22, 2026
Conversation
Contributor
|
It might be good to add something to https://github.com/xapi-project/sm/blob/master/tests/test_LVHDSR.py#L111 that checks the correct values are written to the metadata. |
AnthoineB
force-pushed
the
abo-convert-vdi-ref-to-vdi-uuid-in-get-snapshot-of
branch
2 times, most recently
from
8c604af to
bff23f3
Compare
Contributor
Author
I create a new test because it was changing the original test too much. I also add 2 small patch I find when writing the test. |
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
…ormat Signed-off-by: Anthoine Bourgeois <anthoine.bourgeois@vates.tech>
AnthoineB
force-pushed
the
abo-convert-vdi-ref-to-vdi-uuid-in-get-snapshot-of
branch
from
bff23f3 to
661eed0
Compare
MarkSymsCtx
approved these changes
Jan 15, 2026
TimSmithCtx
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
'scan' function uses SNAPSHOT_OF_TAG as a vdi_uuid. Same, function '_finishSnapshot', part of 'clone', initialize SNAPSHOT_OF_TAG field with a vdi_uuid.
Without this patch the MGT is filled with 'OpaqueRef:' VDI after MGT is recreated.
To reproduce:
<SR UUID>.lvremove /dev/VG_XenStorage-<SR UUID>/MGTxe sr-scan uuid=<SR UUID>