CA-142451: Unit tests

[fquesnel]

Covering changes related to CA-142451.

Signed-off-by: Flavien Quesnel flavien.quesnel@citrix.com

[xen-git]

Can one of the admins verify this patch?

[coveralls]

Coverage increased (+0.44%) when pulling 5a0977c8df4f0bc2601f188aa76791ec6e20c061 on fquesnel:unittestmaster into 66c89ea on xapi-project:master.

[coveralls]

Coverage increased (+0.47%) when pulling 72017f641f9a542a62bff0e1c6665f62fe5f8d50 on fquesnel:unittestmaster into 66c89ea on xapi-project:master.

[coveralls]

Coverage increased (+0.47%) when pulling ab75df0 on fquesnel:unittestmaster into 66c89ea on xapi-project:master.

[matelakat]

Looks good to me, OK to merge!

[germanop]

I can merge but the situation has become a little bit confused.

This are the unit tests for #210. #210 has been merged and then ported in creedence with #213
along with #212.
Now, in creedence there is a backport of the fix plus the unit tests. The latter are not backports, though.
Would not it be easier (and surely less messy) to do everything in master first and then backport?
What are we going to do with this PR? Cherry-pick the code from Creedence and tag is
as "forwardported"?

[matelakat]

@germanop Yes, I think we left with cherry-picking the xs64bit change to master. I agree that it is suboptimal. I can do the cherry picking to master, just let me know. So I guess let's close this PR, and just cherry-pick 2ddae13

The other thing we can do is to close this PR, and care about master branch later.

[germanop]

Nooooo, do not close it!!!
Leave it open, we'll deal with it.

Please let's avoid creating too many PRs for the same reason

[matelakat]

ok.