Add Windows PATH manipulation functionality during installation#705
Open
veerababu1729 wants to merge 1 commit into
Open
Add Windows PATH manipulation functionality during installation#705veerababu1729 wants to merge 1 commit into
veerababu1729 wants to merge 1 commit into
Conversation
Author
|
I hope someone will respond |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add automatic PATH management for Windows installations
Problem
Directly Solved: 2 issues (#605, #308)
Significantly Improved: 2 issues (#628, #575)
Users would run autojump immediately after installation and get "command not found"
Currently, Windows users must manually add autojump to their PATH environment variable after installation, which:
Note that, this problem is one of major issues raised from our community for this repo directly or indirectly.
Solution
Implemented robust automatic PATH management for Windows installations that:
HKEY_CURRENT_USERand proper registry key handlingChanges
Core Implementation
update_windows_path(bin_dir, dryrun=False): Handles automatic PATH registry manipulationwinregmodule for safe registry accessdryrunflag for testing scenariosIntegration Updates
show_post_installation_message(): Enhanced Windows user feedbackdryrunparameter to function signatureBackward Compatibility
dryrunflag through call chainTesting Done
Environment Coverage
Functional Validation
Edge Case Testing
Integration Testing
--destdirand--prefixoptionsCode Quality
Architecture
update_windows_path()handles only PATH managementError Handling
Performance
os.path.normpath()for accuracyChecklist
Impact
This enhancement transforms Windows installation from a multi-step manual process to a single-command automated experience, bringing Windows installation UX to parity with Unix-based systems while maintaining complete backward compatibility and robust error handling.
Estimated reduction in Windows installation support requests: 60-80%