Repository navigation
Explicit Telecommute Specs - #3
Open
i-am-sijia wants to merge 14 commits into
Open
i-am-sijia wants to merge 14 commits into
i-am-sijia wants to merge 14 commits into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Regression artifacts and CI installation do not yet support the new pipeline components.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (4)
What changed in this PR
Adds placeholder telework arrangement and duration models, replacing the prior telecommute-status step in the SANDAG resident pipeline.
Changes:
- Adds telework model configurations, alternatives, probabilities, and coefficients.
- Registers models across standard, multiprocess, and sharrow pipelines.
- Updates annotations and regression expectations.
| File | Reviewed changes |
|---|---|
test/test_sandag_abm3.py |
Registers the new telework model steps. |
configs/resident/telework_duration.yaml |
Configures duration modeling. |
configs/resident/telework_duration.csv |
Defines duration utilities. |
configs/resident/telework_duration_probs.csv |
Provides duration probabilities. |
configs/resident/telework_duration_coeffs.csv |
Provides duration coefficients. |
configs/resident/telework_duration_alts.csv |
Maps duration categories to hours. |
configs/resident/telework_arrangement.yaml |
Configures arrangement modeling. |
configs/resident/telework_arrangement.csv |
Defines arrangement utilities. |
configs/resident/telework_arrangement_coeffs.csv |
Provides arrangement coefficients. |
configs/resident/settings.yaml |
Updates the standard pipeline. |
configs/resident/settings_mp.yaml |
Updates the multiprocess pipeline. |
configs/resident/settings_mp_sharrow.yaml |
Updates the sharrow pipeline. |
configs/resident/annotate_persons_mtf.csv |
Adds daily telework labels. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+75
to
+76
| "telework_arrangement", | ||
| "telework_duration", |
Comment on lines
+75
to
+76
| "telework_arrangement", | ||
| "telework_duration", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently just some placeholder specs to test the software changes in wsp-sag/activitysim#18 . Will be updated with estimated specs.