Skip to content

Update RequestNormalizationValve to support post requests #4555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hwupathum merged 1 commit into from
Mar 25, 2026
+10 −6
Merged

Update RequestNormalizationValve to support post requests #4555

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions ...tomcat.ext/src/main/java/org/wso2/carbon/tomcat/ext/valves/RequestNormalizationValve.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,19 +25,23 @@
import javax.servlet.ServletException;

/**
* Valve that normalizes request URIs by redirecting to remove trailing slashes.
* Only redirects paths longer than "/" that end with trailing slashes and have no query string.
* Valve that normalizes request URIs by redirecting GET requests to remove trailing slashes.
* Only redirects paths longer than "/" that end with trailing slashes. Query strings are preserved.
* Non-GET requests are passed through unchanged to avoid dropping the request body.
*/
public class RequestNormalizationValve extends ValveBase {

@Override
public void invoke(Request request, Response response) throws IOException, ServletException {

String uri = request.getDecodedRequestURI();
String decodedUri = request.getDecodedRequestURI();

if (uri != null && uri.length() > 1 && uri.endsWith("/") && request.getQueryString() == null) {
uri = uri.replaceAll("/+$", "");
response.sendRedirect(uri);
if ("GET".equalsIgnoreCase(request.getMethod()) && decodedUri != null && decodedUri.length() > 1
&& decodedUri.endsWith("/")) {
String rawUri = request.getRequestURI().replaceAll("/+$", "");
String queryString = request.getQueryString();
String location = queryString != null ? rawUri + "?" + queryString : rawUri;
response.sendRedirect(location);
return;
}

Expand Down
Loading