fix: complete Neptune and Postgres state cutover#186
fix: complete Neptune and Postgres state cutover#186jonathanhaaswriter merged 29 commits intomainfrom
Conversation
…iter-main-neptune-pg-cutover-20260330
…ain-neptune-pg-cutover-20260330
- CurrentSecurityGraph: return nil when configured backend errors instead of falling back to empty live graph; preserve live-graph fallback for in-memory mode (no configured backend) - Findings Load: remove LIMIT 10000 so older unresolved findings survive restart; 30-day resolved cutoff still bounds the result set - syncMutation: log Sync errors via slog instead of silently discarding - migrateAgentSessions: guard against missing agent_sessions table in legacy Snowflake (matches migrateFindings pattern) - Agent toolset: fall back to LegacySnowflake when Snowflake is nil in cutover mode so query_assets/get_asset_context continue working - Secret rotation: skip Snowflake rotation when warehouse backend is not snowflake and credentials are absent, instead of hard-failing
28ae404 to
83a99ea
Compare
|
Pushed 7425303 to cover the remaining cutover review regressions. The branch already includes the legacy Postgres findings import, legacy Snowflake agent-session migration fallback, LegacySnowflake tool wiring, and error-propagating Postgres finding mutations; this follow-up adds regression coverage for configured-graph view errors, non-truncated Postgres finding loads, and dropping Snowflake credentials on Postgres secret reloads. |
|
Audited the outstanding review feedback on the current branch head and confirmed the requested fixes are already present: configured-graph errors now return nil instead of silently falling back, legacy Postgres findings import is preserved, legacy Snowflake agent-session migration still backfills transcript history, agent tools fall back to LegacySnowflake in cutover mode, Postgres findings no longer truncate the load window, and mutation sync errors propagate instead of reporting false success. I also reran |
…ne-pg-cutover-20260330 # Conflicts: # internal/api/server_handlers_graph_intelligence_test.go
|
Pushed |
Preserve the legacy Snowflake source when cutover migration or retention still depends on it, rebuild agent tooling/session state safely on reload, and make Postgres findings migration/schema/dedup updates durable. Add regression tests and changed-file staticcheck cleanup for the cutover paths.
…owflake fix(app): harden pg cutover migration and agent tooling refresh
…dir from source control (repo bloat)
Summary
Validation
env GOFLAGS=-mod=vendor go -C "/Users/jonathan/Documents/cerebro-worktrees/writer-main-neptune-pg-cutover-20260330" test ./internal/app ./internal/appstate ./internal/agents ./internal/findings ./internal/api ./internal/cli ./internal/snowflake ./internal/remediation ./scripts/generate_agent_sdk_packages -count=1python3 scripts/devex.py run --mode changed --base-ref writer/mainpython3 scripts/devex.py run --mode pr --base-ref writer/main