-
Notifications
You must be signed in to change notification settings - Fork 813
TEMPO microphysics for WRF #2270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
TEMPO microphysics for WRF #2270
Conversation
|
@AndersJensen-NOAA Can you compile your code on your system with manage_externals? It is showing some errors doing the regression tests. |
@weiwangncar I think that I have the code now working with manage_externals pulling a specific tag of TEMPO. |
Actually, maybe not. Thanks for the email though -- I will check things again. Note that this compiles on my machine, but the regression tests are still failing. |
…tics and optional arguments
|
The regression tests have passed: |
|
@AndersJensen-NOAA Thanks for doing these tests! |
| url = https://github.com/NCAR/MYNN-EDMF | ||
| [submodule "phys/TEMPO"] | ||
| path = phys/TEMPO | ||
| url = https://github.com/AndersJensen-NOAA/TEMPO.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want this to point to your own fork?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this will be switched when you have merged it into the authoritative repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@weiwangncar and @dudhia I will switch this to NCAR/TEMPO next week. I need to push my microphysics changes frist.
|
@AndersJensen-NOAA Can you add a brief summary of the improvement made in this scheme in the PR message? Can you also add a short description for the RELEASE NOTE section - this section will be pulled out to make the Release Notes. You also have a note at the end of the PR: Before this PR is merged, this branch of TEMPO will be merged into the main branch of the authoritative TEMPO repository, https://github.com/NCAR/TEMPO. Has it happened? |
|
Might consider making it option 48 instead of 88, to keep it within the lower numbers. |
@weiwangncar I will work on a list of Bug fixes/improvements. I can do the change to NCAR/TEMPO next week. |


Addition of TEMPO microphysics
TYPE: new feature
KEYWORDS: Microphysics, Operational models
SOURCE: Anders Jensen NOAA/GSL
DESCRIPTION OF CHANGES:
Problem:
Microphysics development of a Thompson-Eidhammer based scheme for operational applications has advanced to a submodule, TEMPO. This new development should be made available to WRF users.
Solution:
Connect TEMPO to WRF. A cleaned and refactored version of TEMPO is being tested in the UFS community's MPAS. Additionally, a PR, MPAS-Dev/MPAS-Model#1393, to add TEMPO to NCAR's MPAS is in progress. This current PR will allow the community to use this same microphysics across the UFS, MPAS, and WRF.
ISSUE: For use when this PR closes an issue.
LIST OF MODIFIED FILES:
M .gitmodules
M main/depends.common
M Makefile
M phys/Makefile
M clean
M phys/module_physics_init.F
M phys/module_microphysics_driver.F
M Registry.EM_COMMON
TESTS CONDUCTED:
RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.
NOTE:
Before this PR is merged, this branch of TEMPO will be merged into the main branch of the authoritative TEMPO repository, https://github.com/NCAR/TEMPO