Skip to content

Conversation

@AndersJensen-NOAA
Copy link

@AndersJensen-NOAA AndersJensen-NOAA commented Jan 9, 2026

Addition of TEMPO microphysics

TYPE: new feature

KEYWORDS: Microphysics, Operational models

SOURCE: Anders Jensen NOAA/GSL

DESCRIPTION OF CHANGES:
Problem:
Microphysics development of a Thompson-Eidhammer based scheme for operational applications has advanced to a submodule, TEMPO. This new development should be made available to WRF users.

Solution:
Connect TEMPO to WRF. A cleaned and refactored version of TEMPO is being tested in the UFS community's MPAS. Additionally, a PR, MPAS-Dev/MPAS-Model#1393, to add TEMPO to NCAR's MPAS is in progress. This current PR will allow the community to use this same microphysics across the UFS, MPAS, and WRF.

ISSUE: For use when this PR closes an issue.

LIST OF MODIFIED FILES:
M .gitmodules
M main/depends.common
M Makefile
M phys/Makefile
M clean
M phys/module_physics_init.F
M phys/module_microphysics_driver.F
M Registry.EM_COMMON

TESTS CONDUCTED:

  1. compiled and ran em_quarter_ss
  2. restart test with em_quarter_ss
  3. bit-for-bit with different number of processes using em_quarter_ss.
  4. Passed regression tests.

RELEASE NOTE: Include a stand-alone message suitable for the inclusion in the minor and annual releases. A publication citation is appropriate.

NOTE:
Before this PR is merged, this branch of TEMPO will be merged into the main branch of the authoritative TEMPO repository, https://github.com/NCAR/TEMPO

@weiwangncar
Copy link
Collaborator

@AndersJensen-NOAA Can you compile your code on your system with manage_externals? It is showing some errors doing the regression tests.

@AndersJensen-NOAA
Copy link
Author

@AndersJensen-NOAA Can you compile your code on your system with manage_externals? It is showing some errors doing the regression tests.

@weiwangncar I think that I have the code now working with manage_externals pulling a specific tag of TEMPO.

@AndersJensen-NOAA
Copy link
Author

AndersJensen-NOAA commented Jan 9, 2026

@AndersJensen-NOAA Can you compile your code on your system with manage_externals? It is showing some errors doing the regression tests.

@weiwangncar I think that I have the code now working with manage_externals pulling a specific tag of TEMPO.

Actually, maybe not. Thanks for the email though -- I will check things again. Note that this compiles on my machine, but the regression tests are still failing.

@AndersJensen-NOAA AndersJensen-NOAA marked this pull request as ready for review January 14, 2026 19:53
@AndersJensen-NOAA AndersJensen-NOAA requested review from a team as code owners January 14, 2026 19:53
@weiwangncar
Copy link
Collaborator

The regression tests have passed:

Test Type              | Expected  | Received |  Failed
= = = = = = = = = = = = = = = = = = = = = = = =  = = = =
Number of Tests        : 23           24
Number of Builds       : 60           57
Number of Simulations  : 158           150        0
Number of Comparisons  : 95           86        0

Failed Simulations are: 
None
Which comparisons are not bit-for-bit: 
None

@islas islas changed the base branch from master to develop January 15, 2026 19:03
@AndersJensen-NOAA
Copy link
Author

@weiwangncar

Output from dmpar compile with intel and em_quarter_ss case with 1 versus 4 processors
Simulation time = 1 hour with output every 30 mins
Last timestep timing information:
4 processors: 0.05787 elapsed seconds
1 processor: 0.14520 elapsed seconds

Screenshot 2026-01-15 at 4 04 16 PM

@AndersJensen-NOAA
Copy link
Author

Restart test: em_quarter_ss case, 2-h simulation with restart files written every hour compared to 1-h simulation started from a restart file at 1 hour:

Screenshot 2026-01-15 at 4 49 29 PM

@weiwangncar
Copy link
Collaborator

@AndersJensen-NOAA Thanks for doing these tests!

url = https://github.com/NCAR/MYNN-EDMF
[submodule "phys/TEMPO"]
path = phys/TEMPO
url = https://github.com/AndersJensen-NOAA/TEMPO.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want this to point to your own fork?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this will be switched when you have merged it into the authoritative repo.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiwangncar and @dudhia I will switch this to NCAR/TEMPO next week. I need to push my microphysics changes frist.

@weiwangncar
Copy link
Collaborator

@AndersJensen-NOAA Can you add a brief summary of the improvement made in this scheme in the PR message? Can you also add a short description for the RELEASE NOTE section - this section will be pulled out to make the Release Notes. You also have a note at the end of the PR: Before this PR is merged, this branch of TEMPO will be merged into the main branch of the authoritative TEMPO repository, https://github.com/NCAR/TEMPO. Has it happened?

@dudhia
Copy link
Collaborator

dudhia commented Jan 28, 2026

Might consider making it option 48 instead of 88, to keep it within the lower numbers.

@AndersJensen-NOAA
Copy link
Author

@AndersJensen-NOAA Can you add a brief summary of the improvement made in this scheme in the PR message? Can you also add a short description for the RELEASE NOTE section - this section will be pulled out to make the Release Notes. You also have a note at the end of the PR: Before this PR is merged, this branch of TEMPO will be merged into the main branch of the authoritative TEMPO repository, https://github.com/NCAR/TEMPO. Has it happened?

@weiwangncar I will work on a list of Bug fixes/improvements. I can do the change to NCAR/TEMPO next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants