Fix CI issues#182
Merged
Merged
Conversation
Member
LinuxJedi
commented
Apr 29, 2026
LinuxJedi
commented
- Fix caching issue with TPM
- Fix NSS version number bump issue
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts CI workflows to address two reported failures: (1) cache collisions/misses in the TPM2 store workflow, and (2) Debian NSS packaging failures caused by debian/changelog hunk context/version drift.
Changes:
- Update the TPM2 store workflow’s wolfSSL cache key to separate
--disable-anonbuilds from prior caches. - Stop patching
debian/changelogviawolfpkcs11-nss-debian.patch, and instead prepend a wolfPKCS11 changelog stanza inline during the Debian pk12util test. - Disable
checkwhen building wolfSSL in the NSS gtests workflow.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/wolfpkcs11-nss-debian.patch |
Removes the debian/changelog hunk; patch now focuses on control/rules changes. |
.github/workflows/tpm2-store-test.yml |
Changes wolfSSL cache key to ...-no-anon to avoid cache collisions. |
.github/workflows/nss.yml |
Sets check: false for the wolfSSL build step. |
.github/workflows/nss-pk12util-debian-test.yml |
Prepends a changelog entry in-script to avoid patch hunk context breakage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Fix caching issue with TPM * Fix NSS version number bump issue
douzzer
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.