Skip to content

Fixed javadoc #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yoedtos wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed javadoc #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ CommandAPDU cmd1 = APDU.builder().setINS(INS.SELECT_FILE).setP1((byte) 0x04)
CommandAPDU cmd2 = APDU.builder().setINS(INS.GET_DATA).setP1((byte) 0x11)
.setData((byte) 0x00, (byte) 0x00).build(); // It's fine to use a byte array to set the data

ListMultimap<CardTerminal, ResponseAPDU> res // Each value stores all ResponseAPDUs of a CardTerminal
Map<CardTerminal, List<ResponseAPDU>> res // Each value stores all ResponseAPDUs of a CardTerminal
= CardReader.getInstance().read(cmd1, cmd2);
```

Expand Down
8 changes: 4 additions & 4 deletions src/main/java/com/github/wnameless/smartcard/CardReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,22 +61,22 @@ public static CardReader getInstance() {
}

/**
* Returns a Multimap&lt;CardTerminal, ResponseAPDU&gt; after executing a set of CommandAPDU on
* Returns a Map&lt;CardTerminal, List&lt;ResponseAPDU&gt;&gt; after executing a set of CommandAPDU on
* all Smartcard readers.
*
* @param commands an array of CommandAPDU
* @return ListMultimap&lt;CardTerminal, ResponseAPDU&gt;
* @return Map&lt;CardTerminal, List&lt;ResponseAPDU&gt;&gt;
*/
public Map<CardTerminal, List<ResponseAPDU>> read(CommandAPDU... commands) {
return read(Arrays.asList(commands));
}

/**
* Returns a Multimap&lt;CardTerminal, ResponseAPDU&gt; after executing a set of CommandAPDU on
* Returns a Map&lt;CardTerminal, List&lt;ResponseAPDU&gt;&gt; after executing a set of CommandAPDU on
* all Smartcard readers.
*
* @param commands a List of CommandAPDU
* @return ListMultimap&lt;CardTerminal, ResponseAPDU&gt;
* @return Map&lt;CardTerminal, List&lt;ResponseAPDU&gt;&gt;
*/
public Map<CardTerminal, List<ResponseAPDU>> read(List<CommandAPDU> commands) {
Map<CardTerminal, List<ResponseAPDU>> responses = new LinkedHashMap<>();
Expand Down