Skip to content

fix: Documents in Recycle Bin should not be editable(WPB-23547)#20921

Merged
arjita-mitra merged 2 commits intodevfrom
fix/recyle-bin-document-editable-WPB-23547
Apr 8, 2026
Merged

fix: Documents in Recycle Bin should not be editable(WPB-23547)#20921
arjita-mitra merged 2 commits intodevfrom
fix/recyle-bin-document-editable-WPB-23547

Conversation

@arjita-mitra
Copy link
Copy Markdown
Contributor

@arjita-mitra arjita-mitra commented Apr 2, 2026

BugWPB-23547 [Web] Documents in Recycle Bin should not be editable

Summary

Documents that have been moved to the Recycle Bin remain editable when on web. Files in the Recycle Bin should be in a read-only state and not allow further modifications.

Steps to Reproduce
Go to a Wire Drive enabled conversation

Upload an editable document (e.g., .docx)

Move the document to the Recycle Bin

Open the document from the Recycle Bin

Attempt to edit the document

Expected Result
Documents in the Recycle Bin should:

Be read-only / Be on preview-only

No modifications should be possible

Editing capabilities (typing, formatting, saving changes) should be disabled


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 14
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 14
  • Total Runtime: 537.8s (~ 8 min 58 sec)

@arjita-mitra arjita-mitra enabled auto-merge April 2, 2026 11:45
Comment thread apps/webapp/src/script/components/FileFullscreenModal/FileFullscreenModal.tsx Outdated
Comment thread apps/webapp/src/script/components/FileFullscreenModal/FileFullscreenModal.tsx Outdated
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 8, 2026

@arjita-mitra arjita-mitra added this pull request to the merge queue Apr 8, 2026
Merged via the queue into dev with commit e402c8f Apr 8, 2026
85 checks passed
@arjita-mitra arjita-mitra deleted the fix/recyle-bin-document-editable-WPB-23547 branch April 8, 2026 11:38
zskhan pushed a commit that referenced this pull request Apr 14, 2026
* fix: Documents in Recycle Bin should not be editable(WPB-23547)

* fix: use dependency injection to test isInRecycleBin and make  explicit default in destructuring isEditMode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants