Skip to content

Wpb 24674 fix qr file picker and downloads#4717

Open
emmaoke-w wants to merge 1 commit intowpb-24675-harden-shared-android-ui-testsfrom
wpb-24674-fix-qr-file-picker-and-downloads
Open

Wpb 24674 fix qr file picker and downloads#4717
emmaoke-w wants to merge 1 commit intowpb-24675-harden-shared-android-ui-testsfrom
wpb-24674-fix-qr-file-picker-and-downloads

Conversation

@emmaoke-w
Copy link
Copy Markdown
Contributor

@emmaoke-w emmaoke-w commented Apr 10, 2026


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Updated QR image creation in FileUtils to use MediaStore on Android Q+ for scoped-storage-safe writes to Downloads.
  • Kept legacy Downloads path handling for older Android versions.
  • Improved DocumentsUI picker handling so tests can switch to Downloads when the picker opens in Recent or another root.
  • Hardened file action modal and download Save handling in conversation view to reduce flaky modal/button interactions

Issues

Briefly describe the issue you have solved or implemented with this pull request. If the PR contains multiple issues, use a bullet list.

  • Fix QR file generation and selection reliability in Android UI tests, especially on newer Android versions and when the system picker opens outside Downloads.

Causes (Optional)

Briefly describe the causes behind the issues. This could be helpful to understand the adopted solutions behind some nasty bugs or complex issues.

Solutions

Briefly describe the solutions you have implemented for the issues explained above.

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@emmaoke-w emmaoke-w changed the base branch from develop to wpb-24675-harden-shared-android-ui-tests April 10, 2026 10:36
@pull-request-size pull-request-size bot added size/S and removed size/L labels Apr 10, 2026
@emmaoke-w emmaoke-w force-pushed the wpb-24674-fix-qr-file-picker-and-downloads branch from 26dbaad to 06af9af Compare April 10, 2026 14:50
@sonarqubecloud
Copy link
Copy Markdown

@emmaoke-w emmaoke-w requested a review from yamilmedina April 10, 2026 14:57
@emmaoke-w emmaoke-w marked this pull request as ready for review April 10, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants