Skip to content

feat(nomad): message restore loading user feedback (WPB-24664)#4714

Open
yamilmedina wants to merge 13 commits intodevelopfrom
nomad/feat/bath-loaderindicato-optb
Open

feat(nomad): message restore loading user feedback (WPB-24664)#4714
yamilmedina wants to merge 13 commits intodevelopfrom
nomad/feat/bath-loaderindicato-optb

Conversation

@yamilmedina
Copy link
Copy Markdown
Contributor

@yamilmedina yamilmedina commented Apr 9, 2026

https://wearezeta.atlassian.net/browse/WPB-24664


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

After delivering #4678 the feature could be improved, but this one was left deprioritized for the first delivery.
This implements the loading indicator while fetching older messages, and improves the logic for rearming/retriggering the fetch when the messages are still available remotely.

Note: reused the existing loader placeholder we have in place. No new copies were added.

Depends on

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Attachments

Screen_Recording_20260409_162303_Wire.Dev.mp4

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 49.74%. Comparing base (8a3abb0) to head (6e2e53e).
⚠️ Report is 1 commits behind head on develop.

⚠️ Current head 6e2e53e differs from pull request most recent head fd1e2cc

Please upload reports for the commit fd1e2cc to get more accurate results.

Files with missing lines Patch % Lines
...rsations/messages/ConversationMessagesViewModel.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4714      +/-   ##
===========================================
- Coverage    49.88%   49.74%   -0.15%     
===========================================
  Files          602      602              
  Lines        20643    20612      -31     
  Branches      3290     3289       -1     
===========================================
- Hits         10298    10253      -45     
- Misses        9379     9394      +15     
+ Partials       966      965       -1     
Files with missing lines Coverage Δ
...rsations/messages/ConversationMessagesViewState.kt 100.00% <100.00%> (ø)
...rsations/messages/ConversationMessagesViewModel.kt 68.78% <83.33%> (+1.39%) ⬆️

... and 6 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3180bb4...fd1e2cc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yamilmedina yamilmedina enabled auto-merge April 10, 2026 12:32
@yamilmedina yamilmedina requested a review from a team as a code owner April 10, 2026 14:10
@yamilmedina yamilmedina requested review from Garzas, emmaoke-w, ohassine and typfel and removed request for a team, Garzas, emmaoke-w, ohassine and typfel April 10, 2026 14:10
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants