Skip to content

fix: stale epoch recovery (WPB-24596)#4039

Open
sbakhtiarov wants to merge 1 commit intorelease/android-cycle-4.23from
fix/stale-epoch-recovery
Open

fix: stale epoch recovery (WPB-24596)#4039
sbakhtiarov wants to merge 1 commit intorelease/android-cycle-4.23from
fix/stale-epoch-recovery

Conversation

@sbakhtiarov
Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-24596

What's new in this PR?

Issues

Stale epoch recovery not working.

Solutions

Remove extra condition for checking if the MLS conversation already exists.
This condition is already checked in the MLSWelcomeHandler (to fix duplicate MLS Welcome handling) and is safe in other call paths.

@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 10, 2026

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit 4810246.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/android-cycle-4.23@ffc848f). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             release/android-cycle-4.23    #4039   +/-   ##
=============================================================
  Coverage                              ?   59.86%           
=============================================================
  Files                                 ?     1974           
  Lines                                 ?    63792           
  Branches                              ?     6951           
=============================================================
  Hits                                  ?    38186           
  Misses                                ?    22476           
  Partials                              ?     3130           
Files with missing lines Coverage Δ
...conversation/JoinExistingMLSConversationUseCase.kt 72.44% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffc848f...4810246. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants