fix: queue one-on-one recovery retries for foreground processing [WPB-24176]#4001
Open
fix: queue one-on-one recovery retries for foreground processing [WPB-24176]#4001
Conversation
github-actions
bot
added
🚨 Potential breaking changes
type: bug / fix 🐞
👕 size: M
labels
|
4 tasks
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #4001 +/- ##
===========================================
- Coverage 59.60% 59.55% -0.05%
===========================================
Files 2025 2027 +2
Lines 65472 65538 +66
Branches 7140 7149 +9
===========================================
+ Hits 39026 39033 +7
- Misses 23254 23312 +58
- Partials 3192 3193 +1
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
Bencher Report
MohamadJaara
reviewed
Apr 8, 2026
Comment on lines
+31
to
+44
| internal class InMemoryPendingOneOnOneResolutionsRepository : PendingOneOnOneResolutionsRepository { | ||
| private val mutex = Mutex() | ||
| private val pendingUserIds = linkedSetOf<UserId>() | ||
|
|
||
| override suspend fun enqueue(userId: UserId) { | ||
| mutex.withLock { | ||
| pendingUserIds.add(userId) | ||
| } | ||
| } | ||
|
|
||
| override suspend fun dequeueAll(): Set<UserId> = mutex.withLock { | ||
| pendingUserIds.toSet().also { pendingUserIds.clear() } | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
this means the resolving will be lost to the void in case of process death is it needed to be in memory or we can persist the q in the DB for example?
sbakhtiarov
reviewed
Apr 8, 2026
| kaliumLogger.e("Resolving one-on-one failed $failure, skipping") | ||
| Either.Right(Unit) | ||
| } else { | ||
| kaliumLogger.e("Resolving one-on-one failed $failure, retrying") |
Contributor
There was a problem hiding this comment.
Is this retry on purpose?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-24176
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
Causes (Optional)
Solutions
MissingKeyPackagesFederatedBackendFailure.RetryableFailureMLSFailure.MessageRejected(StaleMessage)