Open
Conversation
SimonThormeyer
force-pushed
the
simon/test/fetch-crls-e2e-test
branch
4 times, most recently
from
d6001af to
29490d9
Compare
istankovic
reviewed
Apr 2, 2026
istankovic
reviewed
Apr 2, 2026
istankovic
reviewed
Apr 2, 2026
istankovic
reviewed
Apr 2, 2026
SimonThormeyer
force-pushed
the
simon/test/fetch-crls-e2e-test
branch
from
7cab828 to
588a433
Compare
This is necessary because the CRL is fetched via the host port, so we need to alter the config at runtime, after the host port has been determined.
SimonThormeyer
force-pushed
the
simon/test/fetch-crls-e2e-test
branch
from
588a433 to
615dafa
Compare
istankovic
reviewed
Apr 9, 2026
istankovic
reviewed
Apr 9, 2026
Without it, requests on TLS endpoints would fail
SimonThormeyer
force-pushed
the
simon/test/fetch-crls-e2e-test
branch
from
615dafa to
d326af2
Compare
istankovic
reviewed
Apr 10, 2026
| cfg.as_object_mut() | ||
| .unwrap() | ||
| .insert("authority".to_string(), generate_authority_config(ca_cfg)); | ||
| .insert("authority".to_string(), serde_json::from_str(&authority).unwrap()); |
Member
There was a problem hiding this comment.
Here we are calling from_str to convert authority to a serde_json::Value, but a few lines above we generate a serde_json::Value by calling generate_authority_config and immediately convert it to a string. Can't we just use
.insert("authority".to_string(), generate_authority_config(ca_cfg));
like the previous version did?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Test CRL fetching
PR Submission Checklist for internal contributors
SQPIT-764feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.