fix: handle UnionType in validate_type error message#343
Open
williambdean wants to merge 2 commits into
Open
Conversation
The validate_type decorator crashed with AttributeError when formatting error messages for functions annotated with union types (e.g., NormalInverseGamma | NormalGamma) since types.UnionType has no __name__. Now uses str() for UnionType instances and __name__ for regular types.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #343 +/- ##
==========================================
+ Coverage 94.02% 94.04% +0.01%
==========================================
Files 10 10
Lines 1323 1327 +4
==========================================
+ Hits 1244 1248 +4
Misses 79 79 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Regenerated with matplotlib 3.11 to match CI rendering environment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #341
The validate_type decorator crashed with AttributeError when formatting
error messages for functions annotated with union types (e.g.,
NormalInverseGamma | NormalGamma) since types.UnionType has no name.
Now uses str() for UnionType instances and name for regular types.