[WFLY-21838] Add guide about the WildFly EE 10 feature-pack

[jmesnil]

JIRA: https://redhat.atlassian.net/browse/WFLY-21838

[github-actions]

A preview of this PR is available at https://pr-894-wildfly-org.surge.sh

[bstansberry]

Thanks, Jeff! I have some change requests but the basic content is great.

I am a bit unclear about the WildFly Glow aspect though, but that's a gap in my knowledge that I need to fill. :)

[bstansberry]

@jfdenise Will this result in including the wildfly FP?

I'm not too familiar with the semantics of this, since in the WildFly testsuite we couldn't really use this and are specifying the FPs. When specifying two FP we needed to include the following in contexts where a layer didn't explicitly require things from the wildfly FP:

<enforce-input-feature-packs>true</enforce-input-feature-packs>

[jmesnil]

I'll let @jfdenise have the last word but it works with the wildly-maven-plugin 6.0.0.Beta3 & <server-variant>ee-10</server-variant> only

[INFO] --- wildfly:6.0.0.Beta3:package (default) @ getting-started ---
[INFO] Glow is scanning...
Downloading from central: https://repo.maven.apache.org/maven2/org/wildfly/galleon/feature-packs/wildfly-galleon-feature-packs-metadata/maven-metadata.xml
Downloading from jboss-public-repository-group: https://repository.jboss.org/nexus/content/groups/public/org/wildfly/galleon/feature-packs/wildfly-galleon-feature-packs-metadata/maven-metadata.xml
Downloaded from central: https://repo.maven.apache.org/maven2/org/wildfly/galleon/feature-packs/wildfly-galleon-feature-packs-metadata/maven-metadata.xml (996 B at 5.6 kB/s)
Downloaded from jboss-public-repository-group: https://repository.jboss.org/nexus/content/groups/public/org/wildfly/galleon/feature-packs/wildfly-galleon-feature-packs-metadata/maven-metadata.xml (1.0 kB at 5.0 kB/s)
[INFO] Glow scanning DONE.
[INFO] context: bare-metal
[INFO] enabled profile: none
[INFO] WildFly variant: ee-10
[INFO] galleon discovery
[INFO] - feature-packs
   org.wildfly:wildfly-ee-10-feature-pack:40.0.0.Beta1
   org.wildfly:wildfly-galleon-pack:40.0.0.Beta1
- layers
   ee-core-profile-server
   jaxrs

@jfdenise There are gaps in our doc about this new field. It should be described in https://github.com/wildfly/wildfly-glow/blob/main/docs/guide/wildfly-maven-plugin/index.adoc as well

[jfdenise]

@bstansberry , Glow metadata enforces wildfly-galleon-pack even if it doesn't bring layers. @jmesnil thank-you, I am adding it to the glow documentation.

[bstansberry]

Thanks @jmesnil and @jfdenise. I'll unresolve this not because anything further is required but more because I want the discussion visible later, and also because I'll also keep talking. :)

@jmesnil -- some more context for my question above, just as an FYI since you're one of the provisioning SMEs. :) This server-variant setting wasn't really usable for all of the odd cases in the WF testsuite, where I had to make things work upstream/downstream and with different profiles for testing EE 10 vs 11 etc.

I discovered that when explicitly configuring two FPs, wildfly-ee-10 and wildfly, if the discovery didn't find layers provided by 'wildfly' the provisioning.xml would not include the wildfly fp. The <enforce-input-feature-packs>true</enforce-input-feature-packs> setting forced it to do so.

Ignoring 'wildfly' is problematic because the wildfly FP can override packages from wildfly-ee(-10), so if it is not used you get a different server. In particular it overrides the org.jboss.as.product.conf module that controls how the server identifies itself. That led to failures in tests of how the server identifies itself, which nicely revealed the problem.

So it's great that the wildfly FP is automagically used with server-variant. Using server-variant is much simpler than what I did in the TS.

[bstansberry]

This is ready to go other than the version update Jeff noted at #894 (comment). I put the 'hold' label on it just to avoid someone missing that and merging. I don't see any need for further review before merging if the only change is changing that value.

[rhusar]

Fixed title, we are calling these 'feature-pack'

[rhusar]

Needs fixes.

[jmesnil]

@rhusar thanks for the fixes, I've applied all of them except that I used Feature-pack instead of Feature-Pack for titles.
I've also set the version to 40.0.0.Final. The guide is ready to be merged but I've let it on hold to publish it at the same time that WildFly 40 Final is announced)