feat: Support -z pack-relative-relocs#1701
Draft
mati865 wants to merge 7 commits intowild-linker:mainfrom
Draft
Conversation
Member
Author
|
Ah, I have misunderstood that part. That version has to be just declared, not assigned to any symbol. |
Member
Author
|
It works now but doesn't support the major selling point of RELR which is compacting of the addresses via bitmaps. I'm not sure how to approach that as we need sorted entries before they are written for it work (use a temp buffer?). Currently, I'm working around the problem by sorting the entries after they are already written. Clang release (without debuginfo) builds without and with Even without the compaction this is a small win to the size. This is how compacted vs non-compacted entries look like: Performance impact is not bad considering the sort workaround |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doesn't work yet:
I haven't yet figured out how to cleanly synthesise
GLIBC_ABI_DT_RELRversion for__libc_start_mainsymbol. I'd prefer to avoid matching that symbol by the name, but there might be no other choice.