fix(cli): default account funding to testnet#519
Open
parvahuja wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FUNDING_FAILEDwith exit code 1 for unstructured funding failuresWhy
account fundis described as a testnet faucet command, but without--network testnetit currently resolves to mainnet. In a before smoke test,mppx account fund --account codex-cli-ux-before-1780948475printedFunding ... on mainnet, failed againsthttps://rpc.tempo.xyz, and still exited with status 0.Validation
pnpm checkpnpm check:typesVITE_NODE_ENV=unit pnpm test --project cli src/cli/utils.test.tspnpm mppx account create --account codex-cli-ux-demo-1780948460;pnpm mppx account fund --account codex-cli-ux-demo-1780948460printedFunding ... on testnetand completed successfully; account deletedpnpm mppx account fund --account codex-cli-ux-fail-1780948512 --network mainnetreturnedFUNDING_FAILEDand exited 1; account deletedNote: plain
pnpm test src/cli/utils.test.tswithoutVITE_NODE_ENV=unitstill tries to start Tempo localnet in this environment and fails with missing container runtime.