Fix sync-design-system.ps1 default source path - #61
Merged
Merged
Conversation
The default -Source pointed at Documents\Development\workbench\libraries\ design-system, which does not exist. Workbench lives under GitHub\repos\. A plain run without -Source died on "design-system not found". Also reword "canonical" to "source of truth" in the surrounding comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The default
-Sourceinsync-design-system.ps1pointed atC:\Users\Nugget\Documents\Development\workbench\libraries\design-system. That path does not exist — workbench lives underDocuments\Development\GitHub\repos\workbench. A run without an explicit-Sourcedied on the guard: "Canonical design-system not found".Found during the 3.2.0 design-system sync (#60), which only worked because the corrected path was sitting uncommitted in the working tree.
Changes
$Sourcedefault repointed atGitHub\repos\workbench\libraries\design-systemVerification
Test-Pathon the new default returnsTruefrom PowerShell — the same check the script's guard uses. Git Bash reports the old path as traversable, so PowerShell's view is the one that counts here.No C# touched; the script is not part of the build.
Not in scope
Line 26's error message still reads "Canonical design-system not found" — the one spot the reword missed. Left alone deliberately; happy to fold it in if you'd rather it went with this.