Add cross-platform health check fallbacks (#1)#17
Open
xudexing19920829 wants to merge 15 commits into
Open
Conversation
Added comprehensive audit report with 93 TODO/FIXME comments. Closes #49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add cross-platform health check fallbacks
Fixes: #1
Changes
check_memory_usage()now has a cross-platform fallback:/proc/meminfoas before — no change in behavior_check_memory_fallback): Usessysctl -n hw.memsizefor total memory andvm_statfor page-level available memory. Calculates used percentage and returns same(status, detail, pct)tuplefree -bcommand"WARNING"with descriptive message if no method workscheck_load_average()now has a cross-platform fallback:/proc/loadavgas before — no change_check_load_average_fallback): Usesos.getloadavg()which works on macOS, Linux, and BSD. Returns same tuple format with load percentages"WARNING"on platforms withoutgetloadavg(Windows)Additional improvements:
platform.system()to health check output for visibilityAcceptance criteria
check_memory_usage()keeps existing/proc/meminfopath on Linuxsysctl/vm_statcheck_load_average()keeps existing/proc/loadavgpath where availableos.getloadavg()on non-Linux Unix systems(status, detail, value)tuple format