feat: Deterministic container naming for traceability #265#266
Merged
ArthurCRodrigues merged 2 commits intomainfrom Apr 10, 2026
Merged
feat: Deterministic container naming for traceability #265#266ArthurCRodrigues merged 2 commits intomainfrom
ArthurCRodrigues merged 2 commits intomainfrom
Conversation
ArthurCRodrigues
requested changes
Apr 10, 2026
Member
ArthurCRodrigues
left a comment
ArthurCRodrigues
left a comment
There was a problem hiding this comment.
Please remove the emojis from the logs
ArthurCRodrigues
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adopts a deterministic, human-readable naming convention for sandbox containers:
ag-sbx-{lang}-{pool8}-{seq4}.Examples:
ag-sbx-python-a1b2c3d4-0001,ag-sbx-node-a1b2c3d4-0002Changes
sandbox_manager/language_pool.py— Added per-pool sequence counter,_build_container_name()helper, andname=parameter in both gVisor and fallback container creation pathssandbox_manager/sandbox_container.py— Updated__repr__to include container namesandbox_manager/manager.py— Orphan cleanup logs now include container name alongside idtests/unit/test_sandbox_manager.py— Unit tests for name format and sequence incrementingtests/integration/test_sandbox_lifecycle.py— Integration tests for deterministic naming and sequence progressiondocs/architecture/sandbox_manager.md— Documented naming convention in Container Security sectionCloses #265