If an object implements \ArrayAccess, check both array value and property#1531
Open
shish wants to merge 1 commit intowebonyx:masterfrom
Open
If an object implements \ArrayAccess, check both array value and property#1531shish wants to merge 1 commit intowebonyx:masterfrom
shish wants to merge 1 commit intowebonyx:masterfrom
Conversation
mfn
reviewed
Feb 25, 2024
Collaborator
|
Please extend |
spawnia
reviewed
Feb 26, 2024
67585eb to
f2a1729
Compare
spawnia
approved these changes
Dec 3, 2025
Collaborator
spawnia
left a comment
There was a problem hiding this comment.
I plan to include this when I start working on the next major version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have an object which has known properties accessible via properties, and some extra bits added at runtime accessible via
\ArrayAccesssyntax. graphql-php sees the\ArrayAccessand now it thinks that all my fields are null :(My specific use-case is that I had a class like
and everything was working fine, but then I turned it into
and suddenly any query which referred to the "title" field started throwing
Cannot return null for non-nullable field "Post.title"