Fix stock balance corruption across document lifecycle#65
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: SiriusBig <webiumsk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug and impact
Issued stock-linked documents could corrupt inventory balances when users bulk-cancelled, deleted, or edited issued invoices because those lifecycle paths bypassed stock reversal/rebuild logic. Warehouse deletion after issuing all stock could also orphan movement references, and transfers could overdraw a source warehouse into negative stock.
Root cause
Stock movement application was wired into single document issue/cancel, but bulk cancel/delete, single delete, and issued-document update paths mutated document status/lines without balancing stock movements. Warehouse deletion only checked non-zero balances, not movement history, and transfers did not validate source availability.
Fix
Validation
APP_KEY=base64:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA= BTCPAY_BASE_URL=https://example.test BTCPAY_API_KEY=test php artisan test --filter='CompanyStockDocumentMovementTest|CompanyWarehouseTest'.envin this runner and unrelated PHPUnit doc-comment metadata deprecation.