Merged
Conversation
- Updated dependencies to current releases (@webarkit/jsartoolkit-nft, prettier, ts-loader, typescript, webpack) and refreshed yarn.lock. - Adjusted all example import maps to load the shipped ARnft.mjs/ARnft.simd.mjs bundles so the demos resolve correctly after the build. - newer three.js version for the exmples
- fix for issue #339
010af30 to
531bd61
Compare
- ✅ sync README references to the new .mjs helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to use the modern
.mjsmodule format for both the main ARnft library and its Three.js integration, replacing the older.module.jsfiles. It also updates the build workflow to use Yarn caching and updates documentation and example files to reference the new module filenames.Build and workflow updates:
.github/workflows/build.ymlto cache Yarn dependencies instead of npm, and changed the build artifact fromARnft.module.jstoARnft.mjs. [1] [2]Module format migration:
ARnft.module.jsandARnftThreejs.module.jsto the new.mjsformat in all example HTML files, ensuring consistency and compatibility with ES module imports. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15]Documentation updates:
README.mdto reference.mjsfiles in import examples and CDN usage, and replaced the Dependabot badge with a new status badge. [1] [2] [3]