Remove segment from users-sync#2684
Open
foot wants to merge 2 commits into
Open
Conversation
foot
commented
May 6, 2020
foot
commented
Contributor
- Marketo should stay as we're still using that
- Marketo should stay as we're still using that
bboreham
reviewed
Sep 23, 2020
Comment on lines
-49
to
-53
| billingClient := billing_grpc.NewMockBillingClient(ctrl) | ||
| mockSegment := MockSegment{} | ||
| noopMarketo := marketing.NoopMarketoClient{} | ||
|
|
||
| attrSync := New(logger, db, billingClient, &mockSegment, &noopMarketo) |
There was a problem hiding this comment.
It looks to me like this PR should remove mention of Segment from the test, but leave the rest.
Deleting the entire test seems overkill.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.