fix: move installation to postStartCommand for proper user install#40
Merged
Conversation
- install.sh now only installs dependencies and copies postStartCommand.sh - All installation logic moved to postStartCommand.sh - Installs run as the actual user, not root - Auto-update checks commit IDs and re-installs when updates available - Fixes issue where agency-agents/agents-workspace ran before opencode Bump versions: - agency-agents: 0.3.8 -> 0.3.9 - agents-workspace: 0.1.6 -> 0.1.7
The mv command failed when trying to move the downloaded script to /usr/local/share/devcontainer-features/ due to permission restrictions. Now downloads directly to /tmp instead.
- Commit file checks removed since /usr/local/share is not writable - Only check for postStartCommand.sh and user marker - Simpler, more reliable tests
Avoid su prompting for password when already running as the target user
These are in /usr/local/share which is not writable. Using user marker in HOME instead.
- commit files now in ~/.local/share/devcontainer-features/ - removed all references to /usr/local/share for user data - only /usr/local/share used for the postStartCommand script itself
- Create parent directory before writing commit files - Ensures ~/.local/share/devcontainer-features/ exists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump versions: