fix: remove leftover debug output from aprs_general_query#656
Open
chrisdebian wants to merge 1 commit into
Open
fix: remove leftover debug output from aprs_general_query#656chrisdebian wants to merge 1 commit into
chrisdebian wants to merge 1 commit into
Conversation
Two unconditional DW_COLOR_DEBUG / dw_printf("DEBUG: ...") statements
were left in aprs_general_query() with TODO comments marking them for
removal. They printed on every General Query packet regardless of any
debug flag, adding noise to normal operation.
Removes both blocks (query type at line 2649 and footprint coordinates
at line 2726) and their associated TODO comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two
TODO: remove debugmarkers inaprs_general_query()flag unconditional debug print statements that were left in from development:DEBUG: General Query type = "...") on every General Query packetDEBUG: General Query footprint = ...) on every General Query packetBoth use
DW_COLOR_DEBUG/dw_printfunconditionally — not guarded by any quiet flag or compile-time switch — so they produce output during normal operation.Change
Remove both debug blocks and their TODO comments. Net: 10 deletions, 0 insertions.
Compiled and verified clean against
direwolf.hinclude path.