fix: close stale classic completion menus#13944
Open
KRRT7 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
the
external-contributor
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR tightens Classic Completions invalidation so the menu closes after edits remove part of the original replacement prefix, and adds regression coverage for backspacing past the query.
Concerns
- The new prefix check can close Classic Completions while cycling through case-insensitive matches that change casing, because it runs before the existing selected-item guard.
- For this user-facing terminal input behavior change, please include screenshots or a short screen recording demonstrating the completion menu closing end to end.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
KRRT7
force-pushed
the
fix-classic-completions-stale
branch
from
July 18, 2026 12:51
852626e to
b7753c1
Compare
Author
Screen.Recording.2026-07-18.at.8.52.46.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Classic Completions could leave a stale suggestion menu open after the user backspaced past the query that originally produced the results. The short prefix could then re-filter to the entire original result set.
The completion menu now remains valid while the original replacement prefix is intact, but closes when editing removes part of that prefix.
Linked Issue
ready-to-implement.Fixes #13605
Testing
cargo fmt --allcargo nextest run -p warp -E 'test(classic_completions)'cargo clippy -p warp --lib --tests -- -D warningsgit diff --check./script/runScreenshots / Videos
Not included: this is a terminal input behavior change covered by automated tests; no GUI visual layout changed.
Agent Mode
CHANGELOG-BUG-FIX: Close stale Classic Completions menus after editing past the original query.