fix: avoid rendering share modal without a session#13942
Open
KRRT7 wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
the
external-contributor
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR prevents the pane group from marking the share-block modal open until it has confirmed that the terminal session still exists, and quiets the render-time fallback log for stale modal/model races.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed hunks.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a share-modal lifecycle bug where the pane group could mark the modal open before confirming the terminal session existed. That left a modal with no model mounted, causing repeated render-time warnings and unnecessary repaint/logging work.
Linked Issue
ready-to-specorready-to-implement.Testing
cargo nextest run -p warp -E "test(share_block_modal)"cargo clippy -p warp --lib --tests -- -D warningscargo fmt --allgit diff --checkThis is a lifecycle/performance fix with no visual UI change, so screenshots are not applicable.
Changelog
CHANGELOG-BUG-FIX: Avoid repeated share-modal rendering when no terminal session is available.