Skip to content

Reduce Sentry noise from non-actionable report_error! in terminal view #13909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warp-dev-github-integration wants to merge 1 commit into
base: master
Choose a base branch
from
+17 −25
Open

Reduce Sentry noise from non-actionable report_error! in terminal view #13909

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 17 additions & 25 deletions app/src/terminal/view.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5851,9 +5851,9 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
},
) {
report_error!(anyhow::Error::new(e).context(
"Error sending UpdateBlockAgentViewVisibility event"
));
log::warn!(
"Error sending UpdateBlockAgentViewVisibility event: {e:#}"
);
}
}
}
Expand Down Expand Up @@ -5886,9 +5886,9 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
},
) {
report_error!(anyhow::Error::new(e).context(
"Error sending UpdateBlockAgentViewVisibility event"
));
log::warn!(
"Error sending UpdateBlockAgentViewVisibility event: {e:#}"
);
}
}
}
Expand Down Expand Up @@ -7369,7 +7369,7 @@ impl TerminalView {

// Determine DiffMode from the base branch.
if self.current_repo_path.is_none() {
report_error!("Cannot insert PR comments: not in a git repository");
log::warn!("Cannot insert PR comments: not in a git repository");
return;
}

Expand Down Expand Up @@ -9909,9 +9909,7 @@ impl TerminalView {
AliasExpansionSettings::handle(ctx).update(ctx, |settings, ctx| {
if let Err(e) = settings.alias_expansion_enabled.set_value(true, ctx) {
should_dismiss_banner = false;
report_error!(
e.context("Failed to enable alias expansion setting from banner")
);
log::warn!("Failed to enable alias expansion setting from banner: {e:#}");
}
});
if should_dismiss_banner {
Expand Down Expand Up @@ -10238,8 +10236,7 @@ impl TerminalView {
agent_view_visibility: agent_view_visibility.into(),
})
{
report_error!(anyhow::Error::new(e)
.context("Error sending UpdateBlockAgentViewVisibility event"));
log::warn!("Error sending UpdateBlockAgentViewVisibility event: {e:#}");
}
}
}
Expand Down Expand Up @@ -10416,9 +10413,7 @@ impl TerminalView {
if let Err(e) = ai_settings
.codebase_index_speedbump_banner_dismissed_for_repo_paths
.set_value(dismissed_repo_paths, ctx) {
report_error!(e.context(
"Failed to persist 'Codebase indexing speedbump banner dismissed' setting"
));
log::warn!("Failed to persist 'Codebase indexing speedbump banner dismissed' setting: {e:#}");
}
});
}
Expand All @@ -10440,9 +10435,7 @@ impl TerminalView {
.codebase_index_speedbump_banner_globally_dismissed
.set_value(true, ctx)
{
report_error!(e.context(
"Failed to persist 'Codebase indexing speedbump banner globally dismissed' setting"
));
log::warn!("Failed to persist 'Codebase indexing speedbump banner globally dismissed' setting: {e:#}");
}
});
if let Some(banner_state) = self
Expand Down Expand Up @@ -12424,8 +12417,9 @@ impl TerminalView {
},
move |_, res, _| {
if let Err(err) = res {
report_error!(anyhow::Error::new(err)
.context("Error sending UpdateFinishedCommand event"));
log::warn!(
"Error sending UpdateFinishedCommand event: {err:#}"
);
}
},
);
Expand Down Expand Up @@ -14492,9 +14486,7 @@ impl TerminalView {
.agent_mode_setup_banner_shown_for_repo_paths
.set_value(shown_repo_paths, ctx)
{
report_error!(
e.context("Failed to persist 'Agent Mode setup banner shown' setting")
);
log::warn!("Failed to persist 'Agent Mode setup banner shown' setting: {e:#}");
}
});
}
Expand Down Expand Up @@ -25002,7 +24994,7 @@ impl TerminalView {
};
SessionSettings::handle(ctx).update(ctx, |session_settings, ctx| {
if let Err(e) = session_settings.notifications.set_value(new_settings, ctx) {
report_error!(e.context("Error persisting notifications setting"));
log::warn!("Error persisting notifications setting: {e:#}");
}
});

Expand Down Expand Up @@ -25060,7 +25052,7 @@ impl TerminalView {
};
SessionSettings::handle(ctx).update(ctx, |session_settings, ctx| {
if let Err(e) = session_settings.notifications.set_value(new_settings, ctx) {
report_error!(e.context("Error persisting notifications setting"));
log::warn!("Error persisting notifications setting: {e:#}");
}
});

Expand Down
Loading