Add image support in TUI#13908
Open
kevinyang372 wants to merge 4 commits into
Open
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR adds TUI image attachment support, including a new attachment bar, paste/path ingestion, clipboard image handling, input-mode locking, keybindings, and render/model tests.
Concerns
- The PR changes user-visible TUI behavior, but the description does not include the required terminal transcript, render snapshot diff, or
./script/run-tuicapture demonstrating the end-to-end flow. For this user-facing TUI change, please include one of those artifacts before merge. - Pasted image paths are read fully into memory before any explicit byte cap is applied, which can stall or crash the TUI for very large files.
Security
- The pasted-path ingestion path accepts user-controlled file paths and can perform unbounded memory allocation before rejecting oversized images.
Verdict
Found: 0 critical, 2 important, 0 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
force-pushed
the
kevin/add-image-support
branch
from
July 17, 2026 21:21
490d3b8 to
a6a4b07
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds image attachments to Warp's TUI Agent prompts.
Linked Issue
N/A
Testing
./script/run-tuicargo nextest run -p warp_tui --no-fail-fast— 342 passed.cargo nextest run -p warpui_core --features tui --no-fail-fast— 500 passed, 7 skipped.cargo clippy -p warp_tui -p warpui -p warpui_core --all-targets -- -D warnings./script/formatAgent Mode
CHANGELOG-IMPROVEMENT: Added support for attaching images to prompts in Warp's TUI.