Skip to content

support multigroup#52

Draft
LiNk-NY wants to merge 1 commit intodevelfrom
feature/multigroup
Draft

support multigroup#52
LiNk-NY wants to merge 1 commit intodevelfrom
feature/multigroup

Conversation

@LiNk-NY
Copy link
Contributor

@LiNk-NY LiNk-NY commented Jul 2, 2024

This is a draft PR for multigroup support

@LiNk-NY LiNk-NY force-pushed the feature/multigroup branch 2 times, most recently from 849ddb2 to b020437 Compare July 2, 2024 16:06
@LiNk-NY LiNk-NY force-pushed the feature/multigroup branch from b020437 to 495edec Compare August 19, 2024 20:32
@lwaldron
Copy link
Member

@shbrief don't forget this PR!

@lwaldron lwaldron requested a review from shbrief September 15, 2024 23:56
@shbrief
Copy link
Contributor

shbrief commented Sep 19, 2024

@LiNk-NY Is this pull request ready to be merged?

@LiNk-NY
Copy link
Contributor Author

LiNk-NY commented Sep 19, 2024

@shbrief Not yet, the plots have to be updated so that there are multiple panels of pairwise comparisons, IIRC.

@shbrief
Copy link
Contributor

shbrief commented Sep 19, 2024

@LiNk-NY Got it. Yeah, I was wondering how the plotting will be affected by multiple classes. :)

@lwaldron
Copy link
Member

@sdgamboa (and maybe @asyakhl ?) would you take a look at this PR and think about the plotting of multiple classes? I think it would just mean multiple pairwise classic LEfSe plots.

@lwaldron
Copy link
Member

@asyakhl reminder of this pull request to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants