fix(darwin): make Position() and SetPosition() use consistent coordinate systems

[leaanthony]

Summary

• Fix coordinate system inconsistency between Position() and SetPosition() on macOS
• windowGetPosition() now converts Y coordinates to top-origin (matching windowSetPosition())
• windowGetPosition() now applies DPI scale factor (matching windowSetPosition())

This ensures window positions can be saved and restored correctly across application sessions.

Test plan

• Verify window position save/restore works correctly on macOS
• Test on displays with different DPI scale factors
• Confirm Position() values can be passed directly to SetPosition() for consistent round-trip behavior

Fixes #4816

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Fixed window positioning on macOS to consistently apply DPI scaling when computing and setting window coordinates, ensuring correct placement across standard and high‑DPI displays.
  • Resolved position drift when saving/restoring window state, including multi‑monitor setups.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Warning

Rate limit exceeded

@leaanthony has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 18 minutes and 26 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

Walkthrough

Fix macOS window coordinate inconsistency: windowGetPosition and windowSetPosition now both use screen-space coordinates with DPI scaling and a top-origin Y convention to prevent position drift when saving/restoring window state.

Changes

Cohort / File(s)	Summary
macOS window positioning coordinate fix v3/pkg/application/webview_window_darwin.go	windowGetPosition now retrieves screen scale, applies DPI scaling, and converts Y to a top-origin value; windowSetPosition now divides inputs by screen scale and computes Y using screen height to maintain top-origin convention.
Changelog update v3/UNRELEASED_CHANGELOG.md	Added entry under "Fixed" documenting the macOS Position()/SetPosition() coordinate-system fix (references #4816).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Review DPI scale retrieval and usage in both functions (v3/pkg/application/webview_window_darwin.go)
• Verify Y conversion formulas are symmetrical and use frame/ screen heights consistently
• Check integer/float conversions and potential off-by-one rounding

Possibly related PRs

• V3 alpha feature/start window position #3885 — Modifies macOS window positioning code (same file region); related to initial-position/DPI handling.

Suggested labels

Bug, MacOS, v3-alpha, size:XS

Poem

🐰 I hopped across screens both near and far,

Y flipped and scaled like a wandering star.
Now top-origin and DPI sing in tune,
Windows stay put — no more vertical swoon.
Hooray — no drift beneath the moon! 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately and concisely summarizes the main change: making Position() and SetPosition() use consistent coordinate systems on macOS.
Description check	✅ Passed	The PR description provides a clear summary of the fix, test plan, and links to issue #4816, though the template checklist items are incomplete.
Linked Issues check	✅ Passed	The code changes fully address issue #4816 by making windowGetPosition() apply DPI scaling and top-origin Y-coordinate conversion to match windowSetPosition() behavior.
Out of Scope Changes check	✅ Passed	All changes are directly in scope: modifications to windowGetPosition() and windowSetPosition() in darwin.go address the coordinate system issue, and changelog entry documents the fix.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

v3/pkg/application/webview_window_darwin.go (1)

1434-1448: Consider updating the TODO comment about DPI scaling.

The bounds() function now calls windowGetPosition() which applies DPI scaling (returning pixels), but windowGetSize() returns points without scaling. This creates an inconsistency where X and Y are in pixels but Width and Height are in points.

While this is acknowledged by the TODO comment and is out of scope for this PR, you might want to update the TODO to be more specific about this mixed-unit issue to help guide future work.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8c8d4 and 90389c7.

📒 Files selected for processing (1)

• v3/pkg/application/webview_window_darwin.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: Run Go Tests v3 (windows-latest, 1.24)
• GitHub Check: Run Go Tests v3 (ubuntu-latest, 1.24)
• GitHub Check: Run Go Tests v3 (macos-latest, 1.24)
• GitHub Check: semgrep/ci
• GitHub Check: semgrep-cloud-platform/scan
• GitHub Check: Analyze (go)
• GitHub Check: Cloudflare Pages

🔇 Additional comments (1)

v3/pkg/application/webview_window_darwin.go (1)

574-587: LGTM! Coordinate system fix correctly implemented.

The implementation correctly addresses the inconsistency by:

1. Applying DPI scaling via backingScaleFactor to both X and Y coordinates
2. Converting Y from macOS native bottom-origin to top-origin coordinates using (screenFrame.size.height - frame.origin.y - frame.size.height)

The transformations are mathematically inverse to those in windowSetPosition(), ensuring proper round-trip behavior when saving and restoring window positions.

[cloudflare-workers-and-pages]

Deploying wails with    Cloudflare Pages

Latest commit:	90656bd
Status:	⚡️  Build in progress...

View logs

[github-actions]

⚠️ Missing Changelog Update

Hi @leaanthony, please update v3/UNRELEASED_CHANGELOG.md with a description of your changes.

This helps us keep track of changes for the next release.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

⚠️ Missing Changelog Update

Hi @leaanthony, please update v3/UNRELEASED_CHANGELOG.md with a description of your changes.

This helps us keep track of changes for the next release.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud