add nodeSelector, tolerations and nodeAffinity template values - #8
Merged
Conversation
vigneshrajsb
marked this pull request as ready for review
August 18, 2025 20:11
vigneshrajsb
requested review from
Copilot and
vmelikyan
and removed request for
Copilot
August 18, 2025 20:11
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Kubernetes node scheduling configuration options (nodeSelector, nodeAffinity, and tolerations) to the g2krepeater and g2krelay Helm chart templates, enabling users to control pod placement on specific node groups.
- Adds node scheduling template passthrough for both g2krepeater and g2krelay deployments
- Includes comprehensive test coverage for all scheduling configurations and edge cases
- Maintains backward compatibility with existing configurations
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
helm/chart/templates/g2krepeater-deployment.yaml |
Adds nodeSelector, affinity, and tolerations template blocks to deployment spec |
helm/chart/templates/g2krelay-deployment.yaml |
Adds nodeSelector, affinity, and tolerations template blocks to deployment spec |
helm/chart/tests/g2krepeater-deployment_test.yaml |
Comprehensive test coverage for all scheduling configurations including multiple instances |
helm/chart/tests/g2krelay-deployment_test.yaml |
Test coverage for node scheduling configurations in g2krelay deployment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
vmelikyan
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
nodeSelectornodeAffinitytolerationspassthrough in deployment templates to schedule the pods in specific node groups