Skip to content

add nodeSelector, tolerations and nodeAffinity template values - #8

Merged
vigneshrajsb merged 1 commit into
mainfrom
node-selector-tolerations
Aug 18, 2025
Merged

add nodeSelector, tolerations and nodeAffinity template values#8
vigneshrajsb merged 1 commit into
mainfrom
node-selector-tolerations

Conversation

@vigneshrajsb

Copy link
Copy Markdown
Collaborator

What

  • Adds nodeSelector nodeAffinity tolerations passthrough in deployment templates to schedule the pods in specific node groups

@vigneshrajsb
vigneshrajsb marked this pull request as ready for review August 18, 2025 20:11
@vigneshrajsb
vigneshrajsb requested review from Copilot and vmelikyan and removed request for Copilot August 18, 2025 20:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Kubernetes node scheduling configuration options (nodeSelector, nodeAffinity, and tolerations) to the g2krepeater and g2krelay Helm chart templates, enabling users to control pod placement on specific node groups.

  • Adds node scheduling template passthrough for both g2krepeater and g2krelay deployments
  • Includes comprehensive test coverage for all scheduling configurations and edge cases
  • Maintains backward compatibility with existing configurations

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
helm/chart/templates/g2krepeater-deployment.yaml Adds nodeSelector, affinity, and tolerations template blocks to deployment spec
helm/chart/templates/g2krelay-deployment.yaml Adds nodeSelector, affinity, and tolerations template blocks to deployment spec
helm/chart/tests/g2krepeater-deployment_test.yaml Comprehensive test coverage for all scheduling configurations including multiple instances
helm/chart/tests/g2krelay-deployment_test.yaml Test coverage for node scheduling configurations in g2krelay deployment

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@vigneshrajsb
vigneshrajsb merged commit 263a592 into main Aug 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants