Repository navigation
Sync fork main validation changes - #62
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the AFD connector interfaces and metadata handling. It introduces a new AFDConnectorData base class for backend-specific connector metadata payloads and updates update_state_from_dp_metadata to accept a single AFDDPMetadataPayload object instead of multiple arguments. Additionally, it removes recv_handle_list from AFDConnectorMetadata along with its associated wait logic in the FFN model runners, simplifies rank-checking methods, and updates the unit tests to align with these API changes. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Summary
This PR brings the latest fork
mainchanges intoupstream/main.Commits included from
jiangkuaixue123/afd-plugin-1:main:273317882ef27e740afd0502f6c01049623c061cInternalize DP metadata sender selectione689c11d850e32b5313764fd7de4bf3ef121688eRemove connector recv handle listfe87bb1Type connector-specific metadata data8c20faeAlign DP metadata state payloadValidation
Validated DeepSeekV2-Lite 2A2F functionality using model path:
/home/jcz/models/deepseekv2-liteEager 2A2F
Command shape:
tests/e2e/runner.py--device-backend gpu--num-attention-ranks 2--num-ffn-ranks 2--attention-gpus 0,1--ffn-gpus 2,3--max-tokens 8--common-vllm-arg=--trust-remote-codeResult:
city of neighborhoods, and each one hasDBO + CUDA graph 2A2F
Command shape:
tests/e2e/runner.py--device-backend gpu--num-attention-ranks 2--num-ffn-ranks 2--attention-gpus 0,1--ffn-gpus 2,3--max-tokens 8--common-vllm-arg=--trust-remote-code--cuda-graph-full-decode-only--cudagraph-capture-size 8--num-requests 8--request-concurrency 8--enable-dbo--dbo-decode-token-threshold 1--dbo-prefill-token-threshold 8Result:
city of neighborhoods, and each one hasPost-validation cleanup check: