Draft
Conversation
larpon
requested changes
Apr 2, 2025
Contributor
There was a problem hiding this comment.
This wrapping is redefining types already available in the main sdl module. The code in this PR needs a major overhaul for it to be in an acceptable condition to use as a base for the image module. There's also no examples or tests where it is used along with sdl included which would be a bare minimum to ensure the wrapper works and does not regress.
The image.c.v file still has a lot of structs and enums in there that doesn't need to be there. But it works as far as I have used it.
Also when you know something is messy please put some effort into cleaning it up before making a pull request so maintainers does not waste time on it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this for my needs, figured someone might like to use it.
The image.c.v file still has a lot of structs and enums in there that doesn't need to be there. But it works as far as I have used it.