Conversation
Contributor
Author
|
This replaces #20923. |
biagas
force-pushed
the
bugfix/biagas/fix_msaa_availablity_test
branch
from
September 17, 2026 17:37
1a80829 to
2d68ba4
Compare
biagas
marked this pull request as draft
September 17, 2026 19:06
Contributor
Author
|
converted to draft, as I'm looking into an issue with the scroll area changes I made. |
Prevents crash, yet still enables MSAA when avaialable. Makes RenderingAttributes::MSAAAvailablity a tri-state enum: MSAA_AVAILABLE; MSAA_NOT_AVAILABLE; MSAA_UNKOWN.
biagas
force-pushed
the
bugfix/biagas/fix_msaa_availablity_test
branch
from
September 22, 2026 15:47
d56bbb4 to
3631dce
Compare
Update release notes.
biagas
force-pushed
the
bugfix/biagas/fix_msaa_availablity_test
branch
from
September 22, 2026 17:24
3631dce to
b1d991c
Compare
biagas
marked this pull request as ready for review
September 22, 2026 17:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed query of MSAA availability (GL_MAX_SAMPLES > 1) so that it won't crash.
Per @markcmiller86 's suggestion, MSAA availabilty is now represented as an enum: MSAA_AVAILABLE, MSAA_NOT_AVAILABLE, MSAA_UNKNOWN (initial setting). This RenderingAtts field is no longer persistent (e.g. not saved to sessions or configs).
When trying to determine if MSAA is available, a NULL window, or an uninitialized window will return MSAA_UNKNOWN.
If a window is not current and cannot successfully be made current, MSAA_NOT_AVAILABLE is returned.
If querying GL_MAX_SAMPLES returns a value > 1 MSAA_AVAILABLE is returned, otherwise MSAA_NOT_AVAILABLE is returned.
Re-generated attributes.rst (picked up more than just RenderingAttributes changes).
Added QScrollArea's to RenderingWindow for easier display on smaller laptop monitors.backed this out due to issues with sizing.Type of change
[ ] New feature[ ] Documentation update[ ] OtherHow Has This Been Tested?
On Windows and Linux, no crash on startup if a config file has "Scalable" turned on.
On Windows, initial query of MSAAvailable returns 'UNKNOWN', but subsequent returns 'AVAILABLE'
On Linux with VIsIt built agains Mesa, initial query of MSAAvailable returns 'UNKNOWN', but subsequent returns 'NOT_AVAILABLE'.
Checklist:
[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.