Adjust LFS operation order in CI to fail fast if no budget - #21127
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reorders Git LFS test-data fetching in the Azure Pipelines CI job so the pipeline fails early when Git LFS bandwidth/budget is exhausted, instead of spending hours building first.
Changes:
- Adds a dedicated early CI step to pull a limited subset of Git LFS objects required for tests (data tarballs + selected baseline directories).
- Removes the late “Prep Test Data” LFS pull commands and leaves that later step focused solely on unpacking already-fetched archives (renamed to “Unpack Test Data”).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
Author
|
Ok, great. This failed in one minute due to LFS budget exhaustion. Am going to up the budget and restart now. |
Member
Author
|
Ok, also great...I upped the budget by $1 and restarted the failed jobs and they are running now. |
markcmiller86
changed the title
cyrush
approved these changes
Aug 24, 2026
cyrush
left a comment
cyrush
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks for making this change!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I get tired of waiting 2 hours for CI to build VisIt only to have the CI fail due to LFS budget issues after that.
A simple thing to do is to move the LFS operations in the CI to the "top". Do those first and if they succeed, the CI can proceed. Otherwise, it fails fast with very little time waiting.
A second revision could involve the coordination with a GitHub Action that has the ability to incriment the budget and then the azure CI can retry. Still working on that design though.
This is a good change for now.