Add --cleanup option to build_visit. - #21076
Merged
Merged
Conversation
Have modules use new `cleanup_build_dirs` function. This is a no-op if `--cleanup` wasn't used. Also added `change_install_dir_perms` function for consistency. Modified all modules to use the function.
Contributor
Author
|
@cyrush @markcmiller86 do either of you have time to review this PR? |
cyrush
approved these changes
Aug 3, 2026
cyrush
left a comment
cyrush
left a comment
Member
There was a problem hiding this comment.
Looks great, thanks for getting this in!
| } | ||
|
|
||
|
|
||
| # *************************************************************************** |
| chgrp -R ${GROUP} "$VISITDIR/xkbcommon" | ||
| fi | ||
|
|
||
| cleanup_build_dirs $XKBCOMMON_BUILD_DIR |
Member
There was a problem hiding this comment.
nice how helpers clean all of these cases up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Have modules use new
cleanup_build_dirsfunction. This is a no-op if--cleanupwasn't used.Also added
change_install_dir_permsfunction for consistency. Modified all modules to use the function.Resolves #1480
Removed unused function from bv_ospray.
Added blurb to basic usage docs.
Type of change
[ ] Bug fix[ ] New feature[ ] Documentation updatebuild_visit
How Has This Been Tested?
Ran build-visit with everything turned on and
--cleanupadded to command line.After completion, all source and build dirs were removed.
Checklist:
[ ] I have added debugging support to my changes.[ ] I have added tests that prove my fix is effective or that my feature works.[ ] I have confirmed new and existing unit tests pass locally with my changes.[ ] I have added new baselines for any new tests to the repo.[ ] I have NOT made any changes to protocol or public interfaces in an RC branch.